fix: allow periods in parameter identifiers #8022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imnotjames
force-pushed
the
fix/8015/parameter-dots
branch
from
d46cd4b
to
7d80c81
Compare
updates the character set for parameter identifiers to include periods. also update the `setParameter` function on query builder to validate these identifiers to ensure have explicit failures when invalid keys are used
imnotjames
force-pushed
the
fix/8015/parameter-dots
branch
from
7d80c81
to
5710ece
Compare
klerick
pushed a commit
to ringcentral/nestjs-json-api
that referenced
this pull request
Oct 7, 2021
after PR typeorm/typeorm#8022 The filter functional broke Closes #12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
updates the character set for parameter identifiers to include
periods. also update the
setParameterfunction on query builderto validate these identifiers to ensure have explicit failures
when invalid keys are used
fixes #8015
Pull-Request Checklist
masterbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000