Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent using absolute table path in migrations unless required #8038

Merged
merged 3 commits into from Aug 18, 2021
Merged

fix: prevent using absolute table path in migrations unless required #8038

merged 3 commits into from Aug 18, 2021

Conversation

imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Aug 5, 2021 •
edited

Description of change

Fixes #8012

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@imnotjames imnotjames force-pushed the fix/8012/prevent-absolute-table-for-now branch 7 times, most recently from 81e936d to 522f34e Compare August 7, 2021 07:34
@imnotjames imnotjames marked this pull request as ready for review August 7, 2021 16:43
@imnotjames imnotjames force-pushed the fix/8012/prevent-absolute-table-for-now branch 3 times, most recently from 674067f to cb9118e Compare August 14, 2021 15:19
@imnotjames
feat: ensure driver has correct database and schema after connecting
bdd92e5
@imnotjames
fix: prevent using absolute table path in migrations unless required
263d166 
this is mostly to fix some issues where user expectations were
not met.  this is probably something we'll eventually need to do
if we continue to use SQL-based migrations in this way rather than
abstractions
@imnotjames imnotjames force-pushed the fix/8012/prevent-absolute-table-for-now branch from cb9118e to 263d166 Compare August 15, 2021 16:47
@imnotjames imnotjames merged commit e9366b3 into typeorm:master Aug 18, 2021
@imnotjames imnotjames deleted the fix/8012/prevent-absolute-table-for-now branch August 18, 2021 00:07
@ranjan-purbey ranjan-purbey mentioned this pull request Aug 29, 2021
Closed
@atstoyanov atstoyanov mentioned this pull request Sep 3, 2021
Open
@coyoteecd
Copy link
Contributor

@imnotjames changes in this fix are causing Aurora Data API driver to issue a 'SELECT DATABASE' statement when connecting, whereas previously it did not. Is the change required for more than just migrations? Because otherwise it introduces overhead.

@imnotjames
Copy link
Contributor Author

It is required for a variety of reasons, yes.

@martinsantibanez
Copy link
Contributor

Please release this 🙏 this was a breaking change

@philipphaeusle philipphaeusle mentioned this pull request Jun 2, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to remove database name from migrations
3 participants
@imnotjames @coyoteecd @martinsantibanez