Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent flattening of Brackets so we get consistent queries #8048

Merged
merged 1 commit into from Aug 6, 2021
Merged

fix: prevent flattening of Brackets so we get consistent queries #8048

merged 1 commit into from Aug 6, 2021

Conversation

imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Aug 6, 2021 •
edited

Description of change

Fixes a regression where Brackets do not add parentheses if there's only one item in the condition

fixes #8043

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@imnotjames imnotjames force-pushed the fix/8043/remove-brackets-flattening branch 2 times, most recently from 85cc3f2 to d725ae2 Compare August 6, 2021 20:49
@imnotjames imnotjames marked this pull request as draft August 6, 2021 21:05
@imnotjames imnotjames force-pushed the fix/8043/remove-brackets-flattening branch from d725ae2 to bafdc62 Compare August 6, 2021 21:34
@imnotjames imnotjames changed the title fix: remove flattening from Brackets so we get consistent queries fix: prevent flattening of Brackets so we get consistent queries Aug 6, 2021
@imnotjames imnotjames force-pushed the fix/8043/remove-brackets-flattening branch from bafdc62 to 8b51864 Compare August 6, 2021 21:36
@imnotjames imnotjames marked this pull request as ready for review August 6, 2021 21:37
@imnotjames imnotjames force-pushed the fix/8043/remove-brackets-flattening branch from 8b51864 to 8737a07 Compare August 6, 2021 22:01
@imnotjames imnotjames merged commit ab39066 into typeorm:master Aug 6, 2021
@imnotjames imnotjames deleted the fix/8043/remove-brackets-flattening branch August 6, 2021 22:19
adetante pushed a commit to adetante/typeorm that referenced this pull request Aug 7, 2021
@imnotjames @adetante
fix: handle brackets when only one condition is passed (typeorm#8048)
3542555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Brackets not adding brackets on 0.2.36
1 participant
@imnotjames