Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Oracle Implicit Results #8050

Merged
merged 3 commits into from Aug 8, 2021
Merged

Add support for Oracle Implicit Results #8050

merged 3 commits into from Aug 8, 2021

Conversation

adetante
Copy link
Contributor

@adetante adetante commented Aug 7, 2021

Description of change

Add support for Oracle Implicit Results (please see issue #8046 )

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@imnotjames sorry I have to recreate the PR, but this time with unit test

@adetante adetante changed the title Issue 8046 Add support for Oracle Implicit Results Aug 7, 2021
@imnotjames imnotjames merged commit fe78bee into typeorm:master Aug 8, 2021
@adetante adetante deleted the issue-8046 branch August 8, 2021 08:19
@pleerock pleerock mentioned this pull request Aug 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imnotjames imnotjames imnotjames approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adetante @imnotjames