Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SAP HANA inserts used incorrect value for returning query #8072

Merged

Conversation

imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Aug 12, 2021

Description of change

fixes #8007

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@imnotjames
Copy link
Contributor Author

Did manually testing & confirmed with issue reporter that this resolves the issue.

SAP HANA integration tests are difficult to run because of the resource requirements.

@imnotjames imnotjames merged commit 36398db into typeorm:master Aug 12, 2021
@imnotjames imnotjames deleted the fix/8007/sap-query-runner-insert branch August 12, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QueryFailedError (Invalid parameter) occurs at typeorm insert into table for sap (HANA) database
1 participant