feat: add relation options to all tree queries #8080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@imnotjames would be nice if you could merge this PR. As you can see many people are waiting for it. |
imnotjames
reviewed
Oct 10, 2021
|
@pleerock Maybe you could merge this since many developers including me urgently need this. The longer it takes, the more likely merge conflicts will appear. |
|
@TheProgrammer21 thanks for waiting, it took a bit to me to reach your PR. Thank you for contribution! |
Thank you for finally merging and for your work in general! |
HeartPattern
pushed a commit
to HeartPattern/typeorm
that referenced
this pull request
Nov 29, 2021
* feat: add relation options to all tree queries Closes: typeorm#8076 * fix: corrected array index in test case * try to fix failing test * fix: sort the array in order to be able to apply tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8076
Description of change
Added the
relationsoption to all treeRepository methods.Pull-Request Checklist
masterbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000The changes are more or less the same I made in the previous pull request, just that I did it on all other methods too. I created test cases for each method, with and without the option set.