fix: use full path for table lookups #8097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imnotjames
force-pushed
the
fix/7867/table-path-lookup
branch
from
c88a510
to
847f2e4
Compare
nebkat
pushed a commit
to nebkat/typeorm
that referenced
this pull request
Sep 27, 2021
The changes made as part of typeorm#7575 fixed some issues and introduced others. The problem became that the table name would be compared against the EntityMetadata tablePath. This would fail in some cases because while the EntityMetadata would specify database, it'd be the "default"/current database & would be omitted from the table name. To work around that this PR introduces the database & schema on the table objects as well as a fully-qualified table path property which will always include all of them for comparing against EntityMetadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The changes made as part of #7575 fixed some issues and introduced others. The problem became that the table name would be compared against the
EntityMetadatatablePath. This would fail in some cases because while theEntityMetadatawould specifydatabase, it'd be the "default"/current database & would be omitted from the table name.To work around that this PR introduces the database & schema on the table objects as well as a fully-qualified table path property which will always include all of them for comparing against
EntityMetadata.fixes #8109
fixes #8102
fixes #7867
fixes #7812
fixes #7737
fixes #6744
fixes #5960
fixes #5958
fixes #5439
fixes #5304
Pull-Request Checklist
masterbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000