fix: defaults type cast filtering #8144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julius-welink
commented
Aug 30, 2021
julius-welink
commented
Aug 30, 2021
|
How do I get any attention from maintainers? @pleerock ? |
|
Sorry sometimes it takes time for us to find a time to review PRs. Everything looks good, thank you for your contribution! |
HeartPattern
pushed a commit
to HeartPattern/typeorm
that referenced
this pull request
Nov 29, 2021
* fix: defaults type cast filtering This fixes column default value in cockroachdb continuously producing schema changes when there should be none Refs: typeorm#7110 * fix: defaults type cast filtering Remove debugging code Refs: typeorm#7110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes column default value in cockroachdb continuously producing schema changes when there should be none
Refs: #7110
Description of change
I am simply applying an existing postgres fix to cockroachdb. Cockroachdb is postgres "compatible". See #7110
Pull-Request Checklist
masterbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000