Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support DeleteResult in SQLiteDriver #8237

Merged
merged 1 commit into from Oct 2, 2021
Merged

fix: support DeleteResult in SQLiteDriver #8237

merged 1 commit into from Oct 2, 2021

Conversation

imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Oct 2, 2021 •
edited

Description of change

uses the sqlite run function for deletes, updates, and inserts - instead of just inserts. this means the affected count should get through to the query builder

fixes #8120

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@imnotjames imnotjames force-pushed the fix/8120/sqlite-delete-result branch from 2a3dd84 to 8ba691a Compare October 2, 2021 22:05
@imnotjames imnotjames added the hacktoberfest-accepted label hacktoberfest label Oct 2, 2021
@imnotjames imnotjames merged commit b678807 into typeorm:master Oct 2, 2021
@imnotjames imnotjames deleted the fix/8120/sqlite-delete-result branch October 2, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted label hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeleteResult not implemented for SQLite3
1 participant
@imnotjames