Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issue delete column null on after update event subscriber #8318

Merged
merged 2 commits into from Nov 18, 2021
Merged

Conversation

spotykatch
Copy link
Contributor

@spotykatch spotykatch commented Oct 30, 2021

Fixes: #6327
Fixes: #6349

Rewrite this one pr #8227

Description of change

Subscriber afterUpdate now gets entity with changed delete and update date column.

Adds getSoftDeletionReturningColumns method to ReturningResultsEntityUpdator class to get right returning columns and search for entity withDeleted(). Resolves bug in SubjectExecutor class. Adds tests for the issue.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@spotykatch
Copy link
Contributor Author

spotykatch commented Oct 30, 2021

@pleerock pleerock merged commit 8a5e671 into typeorm:master Nov 18, 2021
@pleerock
Copy link
Member

Thank you!

HeartPattern pushed a commit to HeartPattern/typeorm that referenced this pull request Nov 29, 2021
HeartPattern pushed a commit to HeartPattern/typeorm that referenced this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscribers and softRemove softRemove DeleteDateColumn is null at Susbscriber's AfterUpdate method
2 participants