Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 8393 #8394

Merged
merged 11 commits into from Dec 11, 2021
Merged

Fix 8393 #8394

merged 11 commits into from Dec 11, 2021

Conversation

rluvaton
Copy link
Contributor

@rluvaton rluvaton commented Nov 20, 2021

Description of change

Fixes #8393

Added tests and a fix

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@rluvaton rluvaton changed the title Fix 8393 Fix 8393 (WIP) Nov 20, 2021
@rluvaton
Copy link
Contributor Author

What do you think of the proposed solution?

If acceptable, I'll add a test asserting that manager.update(Post, id, {}) won't throw and update the computational fields (date / version / etc)

@rluvaton
Copy link
Contributor Author

rluvaton commented Nov 24, 2021

All tests passed but the failed pipeline failed with:

Segmentation fault (core dumped)

Triggering new build to see if this gets fixed


Edit: Fixed...

@rluvaton rluvaton changed the title Fix 8393 (WIP) Fix 8393 Nov 24, 2021
@rluvaton
Copy link
Contributor Author

Hey @pleerock, ping in case you missed it

@pleerock pleerock merged commit 2834729 into typeorm:master Dec 11, 2021
@pleerock
Copy link
Member

Thank you for contribution! 🎉

@rluvaton rluvaton deleted the fix-8393 branch December 11, 2021 16:10
@rluvaton
Copy link
Contributor Author

Happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When trying to update update: false column with @UpdateDateColumn the update column is updated
2 participants