Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntitySchemaOptions does not support withoutRowid but EntityOptions does #8429

Closed
pthrasher opened this issue Dec 5, 2021 · 0 comments · Fixed by #8432
Closed

EntitySchemaOptions does not support withoutRowid but EntityOptions does #8429

pthrasher opened this issue Dec 5, 2021 · 0 comments · Fixed by #8432

Comments

@pthrasher
Copy link
Contributor

Issue Description

withoutRowid is not an available option in EntitySchemaOptions for sqlite tables.

Expected Behavior

I expect EntitySchemaOptions to allow similar customizability to EntityOptions.

Actual Behavior

EntitySchemaOptions is completely unaware of withoutRowid and doesn't transform it when creating EntityMetadata.

Steps to Reproduce

  1. Create EntitySchema with withoutRowid: true as an option.
  2. Attempt to generate migration.
  3. Notice that none of the table create statements have a trailing "WITHOUT ROWID"

Relevant Database Driver(s)

DB Type Reproducible
aurora-data-api no
aurora-data-api-pg no
better-sqlite3 no
cockroachdb no
cordova no
expo no
mongodb no
mysql no
nativescript no
oracle no
postgres no
react-native no
sap no
sqlite yes
sqlite-abstract yes
sqljs no
sqlserver no

Are you willing to resolve this issue by submitting a Pull Request?

  • ✅ Yes, I have the time, and I know how to start.
  • ✖️ Yes, I have the time, but I don't know how to start. I would need guidance.
  • ✖️ No, I don’t have the time, but I can support (using donations) development.
  • ✖️ No, I don’t have the time and I’m okay to wait for the community / maintainers to resolve this issue.

PR is complete. Just running tests, will submit shortly. :-)

pthrasher pushed a commit to pthrasher/typeorm that referenced this issue Dec 5, 2021
pleerock pushed a commit that referenced this issue Dec 10, 2021
Closes: #8429

Co-authored-by: Thrasher <thrasher@grayshift.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant