Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add comment param to FindOptions. #8545

Merged
merged 3 commits into from Jan 31, 2022

Conversation

nathanjordan
Copy link
Contributor

@nathanjordan nathanjordan commented Jan 19, 2022

Description of change

Allows users to pass in comments for queries issued through the entity manager
like they are for the query builder (added in #6892).

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

Allows users to pass in comments for queries issued through the entity manager
like they are for the query builder.
@nathanjordan
Copy link
Contributor Author

looking at other PRs it seems they also have failing builds for the same reason w/ the connection with such name already exist errors

@pleerock pleerock merged commit ece0da0 into typeorm:master Jan 31, 2022
@pleerock
Copy link
Member

Thank you for contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants