fix: find descendants of a non-existing tree parent #8557
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8556
Description of change
If subquery in findDescendants
CONCAT(${subQuery.getQuery()}, '%')
returns null when entity parent does not exist, the search string becomesLIKE '%'
, because CONCAT ignores NULL. ThisLIKE '%'
results on returning everything instead of nothing.Now with
NULLIF
fix, search will beLIKE NULL
, which returns nothing for a non existing tree parent.In case of Sqlite,
LIKE ${subQuery.getQuery()} || '%'
is already evaluated asLIKE NULL
when subquery returns null.Pull-Request Checklist
master
branchnpm run lint
passes with this changenpm run test
passes with this changeFixes #0000