fix: Lock peer dependencies versions #8597
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR locks down
peerDependencies
to their minor versions.Why
Right now, TypeORM does not lock peer dependencies. So, if someone upgrades a major version of their database driver in their project, and that same upgrade contains breaking changes (like updating the Mongo driver to v4), noticeable and silent errors might happen.
By locking the peerDependency versions, both the build-time type-checks and the tests run in the TypeORM repo will almost guarantee that those driver versions will work, and at least warn the users if they are upgrading to a version of a database driver that still isn't tested or typechecked inside the TypeORM code-base.
What
All peer dependencies were set to the same versions that are currently set in
devDependencies
, since they have been type-checked during previous builds and well tested. Those that weren't previously set indevDependencies
(like@sap/hana-client
) were set to their latest version.Pull-Request Checklist
master
branchnpm run lint
passes with this changenpm run test
passes with this changeFixes #0000