Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds entity-schema support for createForeignKeyConstraints #8606

Merged

Conversation

macwatrousdd
Copy link
Contributor

Description of change

A previous pull request (#7277) added support for createForeignKeyConstraints to EntityRelationOptions but did not extend this support all the way into EntitySchemaRelationOptions

This PR adds this missing piece.

Fixes #8489

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change N/A
  • Documentation has been updated to reflect this change N/A
  • The new commits follow conventions explained in CONTRIBUTING.md

@AlexMesser AlexMesser merged commit f224f24 into typeorm:master Feb 12, 2022
@AlexMesser
Copy link
Collaborator

thank you for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createForeignKeyConstraints is not present in EntitySchemaRelationOptions
2 participants