Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alter relation loader to use transforms when present #8691

Merged
merged 1 commit into from Feb 23, 2022
Merged

fix: alter relation loader to use transforms when present #8691

merged 1 commit into from Feb 23, 2022

Conversation

blueskymonster
Copy link
Contributor

Description of change

Use column transforms when rendering queries during relation loading. Previously, transforms were ignored by the relation loader, causing unexpected values to be put into sql queries.

See #8690 for a description of the expected vs actual behavior. This PR implements the expected behavior.

Fixes #8690

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change. I am struggling to get the test suite running in the first place. I have asked about it in slack.
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change (N/A: this is implementing what I think is the expected behavior. I am of course happy to update docs if there is disagreement on this.)
  • The new commits follow conventions explained in CONTRIBUTING.md

Use column transforms when rendering queries during relation loading. Previously, transforms were ignored by the relation loader, causing unexpected values to be put into sql queries.

Closes: #8690
@pleerock pleerock merged commit 2c2fb29 into typeorm:master Feb 23, 2022
@pleerock
Copy link
Member

Thank you for contribution! 🎉

@blueskymonster blueskymonster deleted the transformer-relation-bug-fix branch February 23, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relations do not render primary key column values correctly when transformers present
2 participants