Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: force web bundlers to ignore index.mjs and use the browser ESM version directly #8710

Merged
merged 1 commit into from Mar 1, 2022
Merged

fix: force web bundlers to ignore index.mjs and use the browser ESM version directly #8710

merged 1 commit into from Mar 1, 2022

Conversation

giladgd
Copy link
Contributor

@giladgd giladgd commented Mar 1, 2022

Description of change

Force web bundlers to ignore index.mjs and use browser/index.js instead

Closes #8709

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change - Testing the way the module is imported is problematic to do from within the module itself
  • Documentation has been updated to reflect this change - N/A
  • The new commits follow conventions explained in CONTRIBUTING.md

@giladgd giladgd changed the title fix: force web bundlers to ignore index.mjs and use the browser ESM version directly fix: force web bundlers to ignore index.mjs and use the browser ESM version directly Mar 1, 2022
@giladgd giladgd mentioned this pull request Mar 1, 2022
Closed
@pleerock pleerock merged commit 411fa54 into typeorm:master Mar 1, 2022
@giladgd giladgd mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parcel2 + TypeORM
2 participants
@giladgd @pleerock