fix: Stop crashing when redis is offline and ignoreErrors on cache op… #8725
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
PR #7630 introduced the
ignoreErrors
flag forConnectionOptions
. For me this updated did not fix my problem (also mentioned in the same PR #7630).From my subjective opinion, typeorm should still function even though redis caching is not available. typeorm will be able to query like regular from the database overall increasing the resilience of systems using typeorm.
This fix adds an
error
callback for the internally used redis client, logging instead of throwing an error whenignoreErrors
is set.Pull-Request Checklist
master
branchnpm run lint
passes with this changenpm run test
passes with this changeFixes #0000