fix: improve DeepPartial recursion #8732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/common/DeepPartial.ts
|
Thank you for contribution! 🎉 |
M-TGH
pushed a commit
to TradeCast/typeorm
that referenced
this pull request
Mar 29, 2022
* fix: improve DeepPartial recursion Closes: typeorm#8681 * type simplification * merging master * format * format Co-authored-by: Umed Khudoiberdiev <pleerock.me@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Similar to the original pull request of #8187, but instead of narrowing primitives first, it checks for the known recursivable (real word?) types first. Otherwise, it will return the original type. It will solve the
Date | stringproblem of that pull request.This also merges the previous simplification made in b93416d to allow for generics.
Fixes #2904
Fixes #8681
Pull-Request Checklist
masterbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000