Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allows user to specify which mysql package should be used #8771

Merged
merged 1 commit into from Mar 22, 2022

Conversation

Ginden
Copy link
Collaborator

@Ginden Ginden commented Mar 21, 2022

Description of change

In attempt to resolve #8534, I'm cherry-picking this small change.

This is necessary to eventually resolve #8713

This allows user using ormconfig.json to specify connector package.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@pleerock
Copy link
Member

I would prefer to have two driver types: "mysql" and "mysql2" in the future (both can extend BaseMysqlDriver, etc) and "mysql" only loads "mysql" and "mysql2" only loads "mysql2". This is a bit breaking, but I think it's okay since majority of users don't use mysql2. Anyway, we can accept it and plan this change in 0.4.0

@pleerock pleerock merged commit 35106df into typeorm:master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeORM tests fail on MySQL 8.0
2 participants