fix: reverted json/jsonb changes introduced in 0.3.1 #8777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have to revert breaking changes introduced in #8766
My assumptions were wrong regarding on how
json/jsonbarrays work in postgres.Also I faced issue that
node-pg(underlying package used by TypeORM for postgres support) doesn't really plays well with JSON arrays, so we must callJSON.stringifyto properly support all JSON use cases (see brianc/node-postgres#374 and brianc/node-postgres#442) for more details.So, this change reverts all breaking changes introduced in 0.3.1 back to how they were in 0.3.0 and earlier versions.
fixes #8772