Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve initialization of custom repository #8782

Merged
merged 2 commits into from Mar 23, 2022
Merged

fix: improve initialization of custom repository #8782

merged 2 commits into from Mar 23, 2022

Conversation

parly
Copy link
Contributor

@parly parly commented Mar 23, 2022

Description of change

This patch fixes initialization of the custom repository. Without this patch, the following queries were not being executed within a transaction.

await dataSource.transaction(async (manager) => {
  const customRepository = manager.withRepository(CustomRepository);
  const data = await customRepository.find({/* ... */});
});

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@pleerock pleerock merged commit 52a641c into typeorm:master Mar 23, 2022
@pleerock
Copy link
Member

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants