Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: applicationName parameter for CockroachDB #8800

Merged
merged 1 commit into from Mar 26, 2022
Merged

feat: applicationName parameter for CockroachDB #8800

merged 1 commit into from Mar 26, 2022

Conversation

alanko0511
Copy link
Contributor

@alanko0511 alanko0511 commented Mar 26, 2022 •
edited

Description of change

Add applicationName parameter in connection option that is missed for CockroachDB. This parameter is supported and tested that the "Application Name" value can be seen in the CockroachDB's console web UI.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@pleerock pleerock merged commit 79b7f5c into typeorm:master Mar 26, 2022
@pleerock
Copy link
Member

thank you

@alanko0511 alanko0511 deleted the feat/cockroachdb_application_name branch March 26, 2022 13:37
M-TGH pushed a commit to TradeCast/typeorm that referenced this pull request Mar 29, 2022
@alanko0511 @M-TGH
feat: applicationName parameter for CockroachDB (typeorm#8800)
0b60139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alanko0511 @pleerock