fix: Use concrete subclass for saving with single table inheritance #8819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleerock
reviewed
Mar 30, 2022
| @@ -81,10 +81,28 @@ export class EntityPersistExecutor { | |||
| if (entityTarget === Object) | |||
| throw new CannotDetermineEntityError(this.mode) | |||
|
|
|||
| var metadata = this.connection.getMetadata(entityTarget) | |||
There was a problem hiding this comment.
can you please use let instead?
When using a STI scheme and an EntityManager or Repository with base class target, the wrong discriminator was written to the database despite giving an concrete entity. This was because of the entity's target being ignored in favor of the target of the Repository or the EntityManager. fixes typeorm#2927
felix-gohla
force-pushed
the
feature/2927-inheritance-types
branch
from
946c54d
to
f4f67c8
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
When using a STI scheme and an EntityManager or Repository with base class target, the wrong discriminator was written to the database despite giving a concrete entity.
This was because of the entity's target being ignored in favour of the target of the Repository or the EntityManager, which then is the (abstract) base class.
This PR introduces a fix by figuring out the concrete subclass of an entity when saving.
Further questions from my side:
childEntityMetadatasfor every entity. What about performance problems?This PR fixes #2927 (which was closed by the author without the problem being resolved).
Pull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #0000