fix: broken shebang parameters of cli-ts-node-commonjs and cli-ts-node-esm on some linux distros
#8821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…node-esm` on some linux distros Changed to nodejs workaround instead of relying on shebang parameters, as they work a bit differently on some linux distros, and using the "-S" parameter breaks the CLI on Windows Closes typeorm#8818
M-TGH
pushed a commit
to TradeCast/typeorm
that referenced
this pull request
Mar 29, 2022
…node-esm` on some linux distros (typeorm#8821) Changed to nodejs workaround instead of relying on shebang parameters, as they work a bit differently on some linux distros, and using the "-S" parameter breaks the CLI on Windows Closes typeorm#8818
|
Good work on the quick fix! When do you think this will be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Added a workaround in nodejs itself to use
ts-nodeinstead of relying on shebang parameters, as they seem to work a bit differently on some linux distros, and using the-Sparameter (#!/usr/bin/env -S node <parameters>) breaks the CLI on Windows.Closes #8818
Pull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #0000