Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve missing ConnectionOptions export in index.ts #8850

Conversation

feather-jmalone
Copy link
Contributor

Closes: #8837

Description of change

Although ConnectionOptions is now deprecated and renamed to DataSourceOptions, the ConnectionOptions class still exists as an alias to maintain backwards compatibility.

The issue however is that ConnectionOptions is not being exported from src/index.ts, resulting in broken backwards compatibility.

This PR adds the appropriate export to the typings.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • [N/A] There are new or updated unit tests validating the change
  • [N/A] Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@pleerock pleerock merged commit 1693a17 into typeorm:master Apr 4, 2022
@pleerock
Copy link
Member

pleerock commented Apr 4, 2022

Thank you for contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The deprecated/alias ConnectionOptions type is no longer exported from typeorm
2 participants