feat: add fake migrations running and reverting #8976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedosama94
force-pushed
the
6195-fake-run-migrations
branch
from
1026ffa
to
6667b1e
Compare
Added a cli option to fake-run or fake-revert a migration, adding to the executed migrations table, but not actually running it. This feature is useful for when migrations are added after the fact or for interoperability between applications which are desired to each keep a consistent migration history Closes: typeorm#6195
ahmedosama94
force-pushed
the
6195-fake-run-migrations
branch
from
6667b1e
to
e0b9651
Compare
pleerock
reviewed
Jun 29, 2022
| @@ -23,6 +23,7 @@ export class MigrationExecutor { | |||
| * each: each migration is run in a separate transaction | |||
| */ | |||
| transaction: "all" | "none" | "each" = "all" | |||
| fake: boolean | |||
There was a problem hiding this comment.
can you please add a description about this feature here as well?
pleerock
reviewed
Jun 29, 2022
| before(async () => { | ||
| dataSources = await createTestingConnections({ | ||
| entities: [__dirname + "/entity/*{.js,.ts}"], | ||
| enabledDrivers: [ |
There was a problem hiding this comment.
why did you explicitly specified all the drivers? it's not scalable, if you want to ignore only one or two drivers - better to add checks in the tests like if (dataSource.options.type === "mongodb") return
|
Thank you for contribution! Can you please address the given comments and resolve the conflicts before I can merge it? Thank you. |
|
thank you for contribution! |
nordinh
pushed a commit
to nordinh/typeorm
that referenced
this pull request
Aug 29, 2022
* feat: add fake migrations running and reverting Added a cli option to fake-run or fake-revert a migration, adding to the executed migrations table, but not actually running it. This feature is useful for when migrations are added after the fact or for interoperability between applications which are desired to each keep a consistent migration history Closes: typeorm#6195 * changed enabled drivers in test * added docs to the property * fixed lint issue Co-authored-by: Umed Khudoiberdiev <pleerock.me@gmail.com> Co-authored-by: Dmitry Zotov <dmzt08@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a cli option to fake-run or fake-revert a migration, adding to the
executed migrations table, but not actually running it. This feature is
useful for when migrations are added after the fact or for
interoperability between applications which are desired to each keep
a consistent migration history
Closes: #6195
Description of change
Extended cli
migration:runandmigration:revertto have a--fake(alias-f) option, to fake run migrations, for migrations added after the fact (similar to Django'spython manage.py migrate --fake). Detailed description in linked issue.Pull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this change ---> SAP skipped as tests threw errors that blocked all tests from being run. Some tests where also failing before the update as well (schema builder > create table), these ones do still fail (at least on my end).Fixes #0000