fix: support postgres column with varchar datatype and uuid_generate_v4() default #9065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v4() default Closes: typeorm#9063
knarfchan
force-pushed
the
fix-varchar-uuid
branch
from
4704bed
to
ff8761b
Compare
knarfchan
changed the title
AlexMesser
approved these changes
Aug 24, 2022
|
thank you for contribution! |
wirekang
pushed a commit
to wirekang/typeorm
that referenced
this pull request
Aug 25, 2022
…efault (typeorm#9065) * fix: support postgres column with varchar datatype and uuid_generate_v4() default Closes: typeorm#9063 * added test Co-authored-by: Dmitry Zotov <dmzt08@gmail.com>
nordinh
pushed a commit
to nordinh/typeorm
that referenced
this pull request
Aug 29, 2022
…efault (typeorm#9065) * fix: support postgres column with varchar datatype and uuid_generate_v4() default Closes: typeorm#9063 * added test Co-authored-by: Dmitry Zotov <dmzt08@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes #9063.
If the column type of a Postgres column is not
uuid, we should not treat it as a generated column, but rather just a column with a default. This will allow us to define columns that are typevarcharwithuuid_generate_v4()while producing the correct migration scripts.I'm not quite sure how to write tests for this fix. Any pointers would be appreciated!
Pull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #0000