Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement new mssql option appName #9213

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Conversation

BitDesert
Copy link
Contributor

@BitDesert BitDesert commented Jul 18, 2022

Description of change

Added a config option for the application name in node-mssql: https://github.com/tediousjs/node-mssql/blob/master/lib/tedious/connection-pool.js#L45

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change - N/A
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@BitDesert BitDesert changed the title add appName feat: implement new mssql option appName Jul 18, 2022
@pleerock pleerock merged commit 51a0ebe into typeorm:master Aug 24, 2022
@pleerock
Copy link
Member

Thank you for contribution! 🎉

wirekang pushed a commit to wirekang/typeorm that referenced this pull request Aug 25, 2022
nordinh pushed a commit to nordinh/typeorm that referenced this pull request Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants