fix: update date utils to parse year correctly for years 1-999 #9236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GentryRiggen
approved these changes
Jul 22, 2022
GentryRiggen
approved these changes
Jul 22, 2022
| */ | ||
| private static formatZerolessValue(value: number): string { | ||
| if (value < 10) return "0" + value | ||
| private static formatZerolessValue(value: number, totalLength = 2): string { |
|
Thank you for contribution! 🎉 |
wirekang
pushed a commit
to wirekang/typeorm
that referenced
this pull request
Aug 25, 2022
…rm#9236) * fix: update date utils to parse year correctly for years 1-999 Closes: typeorm#9230 * fix: commit change to date utils * fix: default total length to 2
nordinh
pushed a commit
to nordinh/typeorm
that referenced
this pull request
Aug 29, 2022
…rm#9236) * fix: update date utils to parse year correctly for years 1-999 Closes: typeorm#9230 * fix: commit change to date utils * fix: default total length to 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Update DateUtils to correctly handle years less than 999. For instance, a date of 0999-01-01 should parse to the same string value with a leading 0 for the year. Previously, the output would not contain the leading 0.
Fixes: #9230
Pull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #0000