Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow space and no-space syntaxes for SQLite constraints #9238

Merged
merged 1 commit into from
Aug 24, 2022
Merged

fix: allow space and no-space syntaxes for SQLite constraints #9238

merged 1 commit into from
Aug 24, 2022

Conversation

Obiwan1995
Copy link
Contributor

Description of change

Fixes #9237

The regex for SQLite constraints now accepts both space and no-space syntaxes for FOREIGN KEY, CHECK and UNIQUE constraints.
Both syntaxes exist on the web:

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change N/A
  • Documentation has been updated to reflect this change N/A
  • The new commits follow conventions explained in CONTRIBUTING.md

@pleerock pleerock merged commit bb07244 into typeorm:master Aug 24, 2022
@pleerock
Copy link
Member

Thank you for contribution! 🎉

wirekang pushed a commit to wirekang/typeorm that referenced this pull request Aug 25, 2022
@Obiwan1995 @wirekang
fix: allow space and no-space syntaxes for SQLite constraints (typeor…
1946e87 
…m#9238)

Closes typeorm#9237

Co-authored-by: Brice Miclo <brice.miclo@socomec.com>
nordinh pushed a commit to nordinh/typeorm that referenced this pull request Aug 29, 2022
@Obiwan1995 @nordinh
fix: allow space and no-space syntaxes for SQLite constraints (typeor…
30f0226 
…m#9238)

Closes typeorm#9237

Co-authored-by: Brice Miclo <brice.miclo@socomec.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQLite: "Cannot read property 'name' of undefined" when loading foreign keys of a table
2 participants
@Obiwan1995 @pleerock