Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle inherited relations insert order #9242

Merged
merged 1 commit into from
Aug 24, 2022
Merged

fix: handle inherited relations insert order #9242

merged 1 commit into from
Aug 24, 2022

Conversation

konradkevin
Copy link
Contributor

Take inheritance into consideration when sorting insert commands

Closes: #9241

Description of change

The insert commands are executed in correct order when an entity has nested relation inherited from a parent entity through @TableInheritance

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #9241
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change N/A
  • The new commits follow conventions explained in CONTRIBUTING.md

fix: handle inherited relations insert order
b1a019d 
Take inheritance into consideration when sorting insert commands

Closes: #9241
@konradkevin konradkevin mentioned this pull request Jul 27, 2022
Closed
@pleerock pleerock merged commit 14dfadb into typeorm:master Aug 24, 2022
@pleerock
Copy link
Member

Thank you for contribution! 🎉

wirekang pushed a commit to wirekang/typeorm that referenced this pull request Aug 25, 2022
@konradkevin @wirekang
fix: handle inherited relations insert order (typeorm#9242)
0464772 
Take inheritance into consideration when sorting insert commands

Closes: typeorm#9241

Co-authored-by: Kevin KONRAD <ext.kevin.konrad@reseau.sncf.fr>
@konradkevin konradkevin mentioned this pull request Aug 25, 2022
Merged
7 tasks
pleerock pushed a commit that referenced this pull request Aug 25, 2022
@konradkevin
fix: handle inherited relations insert order (#9321)
3671887 
Fix forgot comparison operator in #9242

Closes: #9241

Co-authored-by: Kevin KONRAD <ext.kevin.konrad@reseau.sncf.fr>
nordinh pushed a commit to nordinh/typeorm that referenced this pull request Aug 29, 2022
@konradkevin @nordinh
fix: handle inherited relations insert order (typeorm#9242)
67400ac 
Take inheritance into consideration when sorting insert commands

Closes: typeorm#9241

Co-authored-by: Kevin KONRAD <ext.kevin.konrad@reseau.sncf.fr>
nordinh pushed a commit to nordinh/typeorm that referenced this pull request Aug 29, 2022
@konradkevin @nordinh
fix: handle inherited relations insert order (typeorm#9321)
63c8e0e 
Fix forgot comparison operator in typeorm#9242

Closes: typeorm#9241

Co-authored-by: Kevin KONRAD <ext.kevin.konrad@reseau.sncf.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect insert order when cascade inserting parent inherited relations
2 participants
@konradkevin @pleerock