Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle inherited relations insert order #9321

Merged
merged 1 commit into from
Aug 25, 2022
Merged

fix: handle inherited relations insert order #9321

merged 1 commit into from
Aug 25, 2022

Conversation

konradkevin
Copy link
Contributor

@konradkevin konradkevin commented Aug 25, 2022

Fix forgot comparison operator in PR #9242

Related issue: #9241

Description of change

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

Fix forgot comparison operator in #9242

Closes: #9241
@konradkevin
Copy link
Contributor Author

@pleerock I read back the previous PR #9242 after your merge and found out there was a small mistake in it

@pleerock pleerock merged commit 3671887 into typeorm:master Aug 25, 2022
@pleerock
Copy link
Member

Thank you!

nordinh pushed a commit to nordinh/typeorm that referenced this pull request Aug 29, 2022
Fix forgot comparison operator in typeorm#9242

Closes: typeorm#9241

Co-authored-by: Kevin KONRAD <ext.kevin.konrad@reseau.sncf.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants