Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker image that generated by typeorm cli: npx typeorm --init docker #9326

Closed
dafujii opened this issue Aug 26, 2022 · 0 comments · Fixed by #9367 · May be fixed by antz-snyk1/gradle-npm-monorepo-example#5
Closed

Comments

@dafujii
Copy link

dafujii commented Aug 26, 2022

Feature Description

The Problem

Docker image that generated by TypeORM CLI is old.

example:

  • npx typeorm --init docker
  • open docker-compose.yml
version: '3'
services:

  postgres:
    image: "postgres:9.6.1"
    ports:
      - "5432:5432"
    environment:
      POSTGRES_USER: "test"
      POSTGRES_PASSWORD: "test"
      POSTGRES_DB: "test"

I think image: "postgres:9.6.1" is old. So I want to update.

The Solution

Update getDockerComposeTemplate() to use latest.

https://github.com/typeorm/typeorm/blob/master/src/commands/InitCommand.ts#L521

Considered Alternatives

Additional Context

Relevant Database Driver(s)

DB Type Relevant
aurora-mysql no
aurora-postgres no
better-sqlite3 no
cockroachdb no
cordova no
expo no
mongodb no
mysql no
nativescript no
oracle no
postgres no
react-native no
sap no
spanner no
sqlite no
sqlite-abstract no
sqljs no
sqlserver no

Are you willing to resolve this issue by submitting a Pull Request?

  • ✅ Yes, I have the time, and I know how to start.
  • ✖️ Yes, I have the time, but I don't know how to start. I would need guidance.
  • ✖️ No, I don’t have the time, but I can support (using donations) development.
  • ✖️ No, I don’t have the time and I’m okay to wait for the community / maintainers to resolve this issue.
Jacse added a commit to Jacse/typeorm that referenced this issue Sep 11, 2022
Jacse added a commit to Jacse/typeorm that referenced this issue Sep 11, 2022
pleerock pushed a commit that referenced this issue Sep 19, 2022
* feat: update db image versions in docker compose

closes #9326

* Fix postgres version

* Upgrade Docker compose versions

* Fix docker compose version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment