Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #9330 #9332

Merged
merged 4 commits into from
Aug 28, 2022
Merged

fix: #9330 #9332

merged 4 commits into from
Aug 28, 2022

Conversation

rbnayax
Copy link
Contributor

@rbnayax rbnayax commented Aug 28, 2022

Description of change

fix: #9330

Change for...of to for...in

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@rbnayax rbnayax marked this pull request as draft August 28, 2022 12:33
@rbnayax rbnayax marked this pull request as ready for review August 28, 2022 14:20
@pleerock pleerock merged commit 03317a3 into typeorm:master Aug 28, 2022
@pleerock
Copy link
Member

Thank you for contribution! 🎉

@pleerock pleerock mentioned this pull request Aug 28, 2022
Closed
7 tasks
nordinh pushed a commit to nordinh/typeorm that referenced this pull request Aug 29, 2022
@rbnayax @nordinh
fix: bug introduced in CLI (typeorm#9332)
58be2a8 
* fix: typeorm#9330
@rbnayax rbnayax deleted the #9330 branch August 30, 2022 11:57
@antz-snyk antz-snyk mentioned this pull request Nov 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typeorm CLI not usable - Running CLI returns: TypeError: dataSourceFileExports is not iterable
2 participants
@rbnayax @pleerock