fix: typescript 4.8 type issues #9331 #9357
Conversation
| @@ -1354,8 +1354,8 @@ export class EntityManager { | |||
| * sets current EntityManager instance to it. Used to work with custom repositories | |||
| * in transactions. | |||
| */ | |||
| withRepository<Entity extends ObjectLiteral, R extends Repository<Entity>>( | |||
| repository: R, | |||
| withRepository<Entity extends ObjectLiteral, R extends Repository<any>>( | |||
There was a problem hiding this comment.
This gives the right type inference with the new ObjectLiteral constraint
There was a problem hiding this comment.
any? Shouldn't it be ObjectLiteral too?
There was a problem hiding this comment.
it is constrained in the argument itself (line 1358), otherwise the type inference doesn't work
| @@ -8,12 +10,16 @@ export type QueryPartialEntity<T> = { | |||
| /** | |||
| * Make all properties in T optional. Deep version. | |||
| */ | |||
| export type QueryDeepPartialEntity<T> = { | |||
| export type QueryDeepPartialEntity<T> = _QueryDeepPartialEntity< | |||
There was a problem hiding this comment.
Previously, when no specific type was supplied, T was considered unknown. Now, when no type I supplied, T get ObjectLiteral, which doesn't behave nicely here (due to it having a string index), so converting it to unknown fixes the issue and maintains backwards compatibility
There was a problem hiding this comment.
solution is ugly, but looks like other solution requires to much re-do.
regevbr
changed the title
|
Thank you for contribution! 🎉 |
fix: typescript 4.8 type issues typeorm#9331 (typeorm#9357)
Description of change
Fixes #9331 - added type constraints on
Entityto extendObjectLiteral. See issue for more informationPull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #0000