feat: update db image versions in docker compose #9367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Please answer my comments from #9366 here. |
|
Hi @pleerock I've fixed the postgres version, but I'm having a hard time testing/verifying the versions on my M1 mac... Time is pretty short on my end but i'll try to see if I can get it running in the weekend |
Jacse
commented
Sep 15, 2022
docker-compose.yml
Outdated
| @@ -44,7 +29,7 @@ services: | |||
| # mdillon/postgis is postgres + PostGIS (only). if you need additional | |||
| # extensions, it's probably time to create a purpose-built image with all | |||
| # necessary extensions. sorry, and thanks for adding support for them! | |||
| image: "mdillon/postgis:9.6" | |||
| image: "mdillon/postgis:14.5" | |||
There was a problem hiding this comment.
I'm not sure about changing the version of this postgres versus the postgres-12 that's also here
|
@pleerock do you have any functional testing environment that I can boot? Or what's the recommended testing strategy? |
|
you can change local docker-compose file, run all new images and run |
|
Ok awesome, thanks |
|
All tests pass ☑️ |
|
Thank you for contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes #9326
Pull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #0000