fix: Update RelationIdLoader to use DriverUtils.getAlias #9380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update RelationIdLoader to use DriverUtils.getAlias to prevent aliases being possibly trimmed by database.
Closes: #9379
Description of change
Updates
RelationIdLoader
class to useDriverUtils.getAlias
to generate column aliases. This resolves issues with databases that have hard limit on column aliases such as Postgres.I've never contributed to this project so I'm definitely not sure if this fix is correct, but it did resolve the issue with
relationLoadStrategy: query
I was having. There may be other places that don't use this util? Maybe this breaks some other behaviour that expects the columns to be properly named?Pull-Request Checklist
master
branchnpm run format
to apply prettier formattingnpm run test
passes with this changeFixes #0000