Fix parameter escape in SQLiteDriver #9400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqlite does not support boolean parameters. Even though sqlite is able to transform true to 1 and false to 0 there might be some limitations with other implemenations that build up on this. Fixes: typeorm#1981 (again)
3cbbe90 already handles the boolean value transformation so it is not necessary to have additional code in the query runner for handling this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
(Re-)Fixes: #1981
The issue in #1981 re-occurred after 0.3.0 because
nativeParametersbecame deprecated and newfindmethods useparmetersinstead which where not fixed in #7122. This PR adds the boolean parameter escape for all kind of parameters and also makes additional transformations as implemented in theBetterSqlite3QueryRunnerobsolete.The problem seems to be mainly related to the
CordovaDriverwhere I also encountered this problem after migration to > 0.3.0. However, I think it's appropriate to have this fixed in theAbstractSqliteDriverbecause it is obviously affectingBetterSqlite3too and a correct way of handling boolean properties in SQLite anyways :).A similar approach was already submitted via: #9009 which was closed unfortunately but I added test-cases in addition and instead of just converting the boolean values to strings this PR will pass them as numeric query parameters.
Pull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #0000