Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark array arguments to find operators as read-only #9474

Merged
merged 2 commits into from
Nov 5, 2022

Conversation

foxymiles
Copy link
Contributor

Description of change

Mark the array arguments to find operators like In and ArrayContains as readonly. This makes it possible to use them with readonly arrays as parameters without casting or having to make copies.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000 N/A
  • There are new or updated unit tests validating the change N/A
  • Documentation has been updated to reflect this change N/A
  • The new commits follow conventions explained in CONTRIBUTING.md

@AlexMesser AlexMesser merged commit 6eb674b into typeorm:master Nov 5, 2022
@foxymiles foxymiles deleted the readonly-operators branch November 6, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants