Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix orm utils prototype check #9517

Merged
merged 1 commit into from
Nov 5, 2022
Merged

Fix orm utils prototype check #9517

merged 1 commit into from
Nov 5, 2022

Conversation

nekomi2
Copy link
Contributor

@nekomi2 nekomi2 commented Nov 2, 2022

Description of change

Fixes OrmUtils crashing when checking objects with null prototype. Instead, always returns false. This is recommended by eslint https://eslint.org/docs/latest/rules/no-prototype-builtins

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@nekomi2 nekomi2 force-pushed the fix-ormUtils-prototype-check branch from a2b3b50 to bd3afa7 Compare November 2, 2022 12:58
@AlexMesser AlexMesser merged commit 19536ed into typeorm:master Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nekomi2 @AlexMesser