Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] sourceKey missing from HasOneOptions #175

Open
billybarnum opened this issue Nov 11, 2018 · 1 comment
Open

[v5] sourceKey missing from HasOneOptions #175

billybarnum opened this issue Nov 11, 2018 · 1 comment

Comments

@billybarnum
Copy link

I previously submitted issue #29414 for v4 that scope was missing from AssociationOptionsBelongsTo and sourceKey was missing from AssociationOptionsHasOne.

It looks like BelongsToOptions now has scope (inherited from AssociationOptions), so that is fixed. However sourceKey is still missing from HasOneOptions. It probably needs to be added to AssociationOptions as well, but I'll let you guys decide that.

I'm working with some legacy databases and I'm broken without this. Worse, I can't seem to patch it locally with declare module overrides as I could in v4, now that the typings are distributed in different files. Any help there appreciated; my typescript experience is ... modest.

Thanks,

-Billy

@billybarnum billybarnum changed the title sourceKey missing from HasOneOptions [v5] sourceKey missing from HasOneOptions Nov 11, 2018
@billybarnum
Copy link
Author

billybarnum commented Nov 11, 2018

This is a pretty easy fix so I went ahead and fixed it locally on my box. I elected to add sourceKey to AssociationOptions since sourceKey applies to more than one type of association.

However, I don't have write access to the repo and I can't push it up. I've never made a PR to a public repo before; what's the procedure? Do I really submit a PR from a fork, or do you guys grant me access, or ... ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant