/
no-useless-constructor.test.ts
100 lines (97 loc) · 3.49 KB
/
no-useless-constructor.test.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
import rule from '../../src/rules/no-useless-constructor';
import { RuleTester } from '../RuleTester';
const ruleTester = new RuleTester({
parserOptions: {
ecmaVersion: 6,
sourceType: 'module',
},
parser: '@typescript-eslint/parser',
});
// the base rule doesn't use a message id...
const error: any = {
message: 'Useless constructor.',
type: 'MethodDefinition',
};
ruleTester.run('no-useless-constructor', rule, {
valid: [
'class A { }',
'class A { constructor(){ doSomething(); } }',
'class A extends B { constructor(){} }',
"class A extends B { constructor(){ super('foo'); } }",
'class A extends B { constructor(foo, bar){ super(foo, bar, 1); } }',
'class A extends B { constructor(){ super(); doSomething(); } }',
'class A extends B { constructor(...args){ super(...args); doSomething(); } }',
'class A { dummyMethod(){ doSomething(); } }',
'class A extends B.C { constructor() { super(foo); } }',
'class A extends B.C { constructor([a, b, c]) { super(...arguments); } }',
'class A extends B.C { constructor(a = f()) { super(...arguments); } }',
'class A extends B { constructor(a, b, c) { super(a, b); } }',
'class A extends B { constructor(foo, bar){ super(foo); } }',
'class A extends B { constructor(test) { super(); } }',
'class A extends B { constructor() { foo; } }',
'class A extends B { constructor(foo, bar) { super(bar); } }',
// https://github.com/typescript-eslint/typescript-eslint/issues/15
'declare class A { constructor(); }',
'class A { constructor(); }',
'abstract class A { constructor(); }',
'abstract class A { abstract constructor(); }',
// https://github.com/typescript-eslint/typescript-eslint/issues/48
'class A { constructor(private name: string) {} }',
'class A { constructor(public name: string) {} }',
'class A { constructor(protected name: string) {} }',
// https://github.com/typescript-eslint/typescript-eslint/pull/167#discussion_r252638401
'class A { private constructor() {} }',
'class A { protected constructor() {} }',
'class A extends B { public constructor() {} }',
'class A extends B { protected constructor(foo, bar) { super(bar); } }',
'class A extends B { private constructor(foo, bar) { super(bar); } }',
'class A extends B { public constructor(foo){ super(foo); } }',
'class A extends B { public constructor(foo){} }',
// type definition / overload
'class A { constructor(foo); }',
],
invalid: [
{
code: 'class A { constructor(){} }',
errors: [error],
},
{
code: "class A { 'constructor'(){} }",
errors: [error],
},
{
code: 'class A extends B { constructor() { super(); } }',
errors: [error],
},
{
code: 'class A extends B { constructor(foo){ super(foo); } }',
errors: [error],
},
{
code: 'class A extends B { constructor(foo, bar){ super(foo, bar); } }',
errors: [error],
},
{
code: 'class A extends B { constructor(...args){ super(...args); } }',
errors: [error],
},
{
code: 'class A extends B.C { constructor() { super(...arguments); } }',
errors: [error],
},
{
code:
'class A extends B { constructor(a, b, ...c) { super(...arguments); } }',
errors: [error],
},
{
code:
'class A extends B { constructor(a, b, ...c) { super(a, b, ...c); } }',
errors: [error],
},
{
code: 'class A { public constructor() {} }',
errors: [error],
},
],
});