-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
/
isUnsafeAssignment.test.ts
211 lines (173 loc) · 6.44 KB
/
isUnsafeAssignment.test.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
import { parseForESLint } from '@typescript-eslint/parser';
import type { TSESTree } from '@typescript-eslint/utils';
import path from 'path';
import type * as ts from 'typescript';
import { isUnsafeAssignment } from '../src/isUnsafeAssignment';
import { expectToHaveParserServices } from './test-utils/expectToHaveParserServices';
describe('isUnsafeAssignment', () => {
const rootDir = path.join(__dirname, 'fixtures');
function getTypes(code: string): {
sender: ts.Type;
senderNode: TSESTree.Node;
receiver: ts.Type;
checker: ts.TypeChecker;
} {
const { ast, services } = parseForESLint(code, {
project: './tsconfig.json',
filePath: path.join(rootDir, 'file.ts'),
tsconfigRootDir: rootDir,
});
expectToHaveParserServices(services);
const checker = services.program.getTypeChecker();
const esTreeNodeToTSNodeMap = services.esTreeNodeToTSNodeMap;
const declaration = ast.body[0] as TSESTree.VariableDeclaration;
const declarator = declaration.declarations[0];
return {
receiver: checker.getTypeAtLocation(
esTreeNodeToTSNodeMap.get(declarator.id),
),
sender: checker.getTypeAtLocation(
esTreeNodeToTSNodeMap.get(declarator.init!),
),
senderNode: declarator.init!,
checker,
};
}
describe('unsafe', () => {
function expectTypesAre(
result: ReturnType<typeof isUnsafeAssignment>,
checker: ts.TypeChecker,
senderStr: string,
receiverStr: string,
): void {
expect(result).toBeTruthy();
const { sender, receiver } = result as Exclude<typeof result, false>;
expect(checker.typeToString(sender)).toBe(senderStr);
expect(checker.typeToString(receiver)).toBe(receiverStr);
}
it('any to a non-any', () => {
const { sender, receiver, checker } = getTypes(
'const test: string = (1 as any);',
);
expectTypesAre(
isUnsafeAssignment(sender, receiver, checker, null),
checker,
'any',
'string',
);
});
it('any in a generic position to a non-any', () => {
const { sender, receiver, checker } = getTypes(
'const test: Set<string> = new Set<any>();',
);
expectTypesAre(
isUnsafeAssignment(sender, receiver, checker, null),
checker,
'Set<any>',
'Set<string>',
);
});
it('any in a generic position to a non-any (multiple generics)', () => {
const { sender, receiver, checker } = getTypes(
'const test: Map<string, string> = new Map<string, any>();',
);
expectTypesAre(
isUnsafeAssignment(sender, receiver, checker, null),
checker,
'Map<string, any>',
'Map<string, string>',
);
});
it('any[] in a generic position to a non-any[]', () => {
const { sender, receiver, checker } = getTypes(
'const test: Set<string[]> = new Set<any[]>();',
);
expectTypesAre(
isUnsafeAssignment(sender, receiver, checker, null),
checker,
'Set<any[]>',
'Set<string[]>',
);
});
it('any in a generic position to a non-any (nested)', () => {
const { sender, receiver, checker } = getTypes(
'const test: Set<Set<Set<string>>> = new Set<Set<Set<any>>>();',
);
expectTypesAre(
isUnsafeAssignment(sender, receiver, checker, null),
checker,
'Set<Set<Set<any>>>',
'Set<Set<Set<string>>>',
);
});
});
describe('safe', () => {
it('non-any to a non-any', () => {
const { sender, receiver, checker } = getTypes(
'const test: string = "";',
);
expect(isUnsafeAssignment(sender, receiver, checker, null)).toBeFalsy();
});
it('non-any to a any', () => {
const { sender, receiver, checker } = getTypes('const test: any = "";');
expect(isUnsafeAssignment(sender, receiver, checker, null)).toBeFalsy();
});
it('non-any in a generic position to a non-any', () => {
const { sender, receiver, checker } = getTypes(
'const test: Set<string> = new Set<string>();',
);
expect(isUnsafeAssignment(sender, receiver, checker, null)).toBeFalsy();
});
it('non-any in a generic position to a non-any (multiple generics)', () => {
const { sender, receiver, checker } = getTypes(
'const test: Map<string, string> = new Map<string, string>();',
);
expect(isUnsafeAssignment(sender, receiver, checker, null)).toBeFalsy();
});
it('non-any[] in a generic position to a non-any[]', () => {
const { sender, receiver, checker } = getTypes(
'const test: Set<string[]> = new Set<string[]>();',
);
expect(isUnsafeAssignment(sender, receiver, checker, null)).toBeFalsy();
});
it('non-any in a generic position to a non-any (nested)', () => {
const { sender, receiver, checker } = getTypes(
'const test: Set<Set<Set<string>>> = new Set<Set<Set<string>>>();',
);
expect(isUnsafeAssignment(sender, receiver, checker, null)).toBeFalsy();
});
it('non-any in a generic position to a any (nested)', () => {
const { sender, receiver, checker } = getTypes(
'const test: Set<Set<Set<any>>> = new Set<Set<Set<string>>>();',
);
expect(isUnsafeAssignment(sender, receiver, checker, null)).toBeFalsy();
});
it('any to a unknown', () => {
const { sender, receiver, checker } = getTypes(
'const test: unknown = [] as any;',
);
expect(isUnsafeAssignment(sender, receiver, checker, null)).toBeFalsy();
});
it('any[] in a generic position to a unknown[]', () => {
const { sender, receiver, checker } = getTypes(
'const test: unknown[] = [] as any[]',
);
expect(isUnsafeAssignment(sender, receiver, checker, null)).toBeFalsy();
});
it('any in a generic position to a unknown (nested)', () => {
const { sender, receiver, checker } = getTypes(
'const test: Set<Set<Set<unknown>>> = new Set<Set<Set<any>>>();',
);
expect(isUnsafeAssignment(sender, receiver, checker, null)).toBeFalsy();
});
// https://github.com/typescript-eslint/typescript-eslint/issues/2109
it('special cases the empty map constructor with no generics', () => {
const { sender, senderNode, receiver, checker } = getTypes(
'const test: Map<string, string> = new Map();',
);
expect(
isUnsafeAssignment(sender, receiver, checker, senderNode),
).toBeFalsy();
});
});
});