/
no-unnecessary-condition.test.ts
134 lines (123 loc) · 3.88 KB
/
no-unnecessary-condition.test.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
import path from 'path';
import rule from '../../src/rules/no-unnecessary-condition';
import { RuleTester } from '../RuleTester';
const rootPath = path.join(process.cwd(), 'tests/fixtures/');
const ruleTester = new RuleTester({
parser: '@typescript-eslint/parser',
parserOptions: {
tsconfigRootDir: rootPath,
project: './tsconfig.json',
},
});
type MessageId = 'alwaysTruthy' | 'alwaysFalsy' | 'never';
const ruleError = (line: number, column: number, messageId: MessageId) => ({
messageId,
line,
column,
});
const necessaryConditionTest = (condition: string) => `
declare const b1: ${condition};
declare const b2: boolean;
const t1 = b1 && b2;
`;
const unnecessaryConditionTest = (condition: string, messageId: MessageId) => ({
code: necessaryConditionTest(condition),
errors: [ruleError(4, 12, messageId)],
});
ruleTester.run('no-unnecessary-conditionals', rule, {
valid: [
`
declare const b1: boolean;
declare const b2: boolean;
const t1 = b1 && b2;
const t2 = b1 || b2;
if(b1 && b2) {}
while(b1 && b2) {}
for (let i = 0; (b1 && b2); i++) { break; }
const t1 = (b1 && b2) ? 'yes' : 'no'`,
necessaryConditionTest('false | 5'), // Truthy literal and falsy literal
necessaryConditionTest('boolean | "foo"'), // boolean and truthy literal
necessaryConditionTest('0 | boolean'), // boolean and falsy literal
necessaryConditionTest('boolean | object'), // boolean and always-truthy type
necessaryConditionTest('false | object'), // always truthy type and falsy literal
// always falsy type and always truthy type
necessaryConditionTest('null | object'),
necessaryConditionTest('undefined | true'),
necessaryConditionTest('void | true'),
necessaryConditionTest('any'), // any
necessaryConditionTest('unknown'), // unknown
// Generic type params
`
function test<T extends string>(t: T) {
return t ? 'yes' : 'no'
}`,
// Supports ignoring the RHS
{
code: `
declare const b1: boolean;
declare const b2: true;
if(b1 && b2) {}`,
options: [{ ignoreRhs: true }],
},
],
invalid: [
// Ensure that it's checking in all the right places
{
code: `
const b1 = true;
declare const b2: boolean;
const t1 = b1 && b2;
const t2 = b1 || b2;
if(b1 && b2) {}
while(b1 && b2) {}
for (let i = 0; (b1 && b2); i++) { break; }
const t1 = (b1 && b2) ? 'yes' : 'no'`,
errors: [
ruleError(4, 12, 'alwaysTruthy'),
ruleError(5, 12, 'alwaysTruthy'),
ruleError(6, 4, 'alwaysTruthy'),
ruleError(7, 7, 'alwaysTruthy'),
ruleError(8, 18, 'alwaysTruthy'),
ruleError(9, 13, 'alwaysTruthy'),
],
},
// Ensure that it's complaining about the right things
unnecessaryConditionTest('object', 'alwaysTruthy'),
unnecessaryConditionTest('object | true', 'alwaysTruthy'),
unnecessaryConditionTest('"" | false', 'alwaysFalsy'), // Two falsy literals
unnecessaryConditionTest('"always truthy"', 'alwaysTruthy'),
unnecessaryConditionTest(`undefined`, 'alwaysFalsy'),
unnecessaryConditionTest('null', 'alwaysFalsy'),
unnecessaryConditionTest('void', 'alwaysFalsy'),
unnecessaryConditionTest('never', 'never'),
// Generic type params
{
code: `
function test<T extends object>(t: T) {
return t ? 'yes' : 'no'
}`,
errors: [ruleError(3, 10, 'alwaysTruthy')],
},
// Still errors on in the expected locations when ignoring RHS
{
options: [{ ignoreRhs: true }],
code: `
const b1 = true;
const b2 = false;
const t1 = b1 && b2;
const t2 = b1 || b2;
if(b1 && b2) {}
while(b1 && b2) {}
for (let i = 0; (b1 && b2); i++) { break; }
const t1 = (b1 && b2) ? 'yes' : 'no'`,
errors: [
ruleError(4, 12, 'alwaysTruthy'),
ruleError(5, 12, 'alwaysTruthy'),
ruleError(6, 4, 'alwaysTruthy'),
ruleError(7, 7, 'alwaysTruthy'),
ruleError(8, 18, 'alwaysTruthy'),
ruleError(9, 13, 'alwaysTruthy'),
],
},
],
});