/
no-extra-parens.ts
232 lines (219 loc) · 6.98 KB
/
no-extra-parens.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
import {
AST_NODE_TYPES,
TSESTree,
TSESLint,
} from '@typescript-eslint/experimental-utils';
import baseRule from 'eslint/lib/rules/no-extra-parens';
import * as util from '../util';
type Options = util.InferOptionsTypeFromRule<typeof baseRule>;
type MessageIds = util.InferMessageIdsTypeFromRule<typeof baseRule>;
export default util.createRule<Options, MessageIds>({
name: 'no-extra-parens',
meta: {
type: 'layout',
docs: {
description: 'disallow unnecessary parentheses',
category: 'Possible Errors',
recommended: false,
},
fixable: 'code',
schema: baseRule.meta.schema,
messages: baseRule.meta.messages,
},
defaultOptions: ['all'],
create(context) {
const rules = baseRule.create(context);
function binaryExp(
node: TSESTree.BinaryExpression | TSESTree.LogicalExpression,
) {
const rule = rules.BinaryExpression as (n: typeof node) => void;
// makes the rule think it should skip the left or right
if (node.left.type === AST_NODE_TYPES.TSAsExpression) {
return rule({
...node,
left: {
...node.left,
type: AST_NODE_TYPES.BinaryExpression as any,
},
});
}
if (node.right.type === AST_NODE_TYPES.TSAsExpression) {
return rule({
...node,
right: {
...node.right,
type: AST_NODE_TYPES.BinaryExpression as any,
},
});
}
return rule(node);
}
function callExp(node: TSESTree.CallExpression | TSESTree.NewExpression) {
const rule = rules.CallExpression as (n: typeof node) => void;
if (node.callee.type === AST_NODE_TYPES.TSAsExpression) {
// reduces the precedence of the node so the rule thinks it needs to be wrapped
return rule({
...node,
callee: {
...node.callee,
type: AST_NODE_TYPES.SequenceExpression as any,
},
});
}
return rule(node);
}
function unaryUpdateExpression(
node: TSESTree.UnaryExpression | TSESTree.UpdateExpression,
) {
const rule = rules.UnaryExpression as (n: typeof node) => void;
if (node.argument.type === AST_NODE_TYPES.TSAsExpression) {
// reduces the precedence of the node so the rule thinks it needs to be wrapped
return rule({
...node,
argument: {
...node.argument,
type: AST_NODE_TYPES.SequenceExpression as any,
},
});
}
return rule(node);
}
const overrides: TSESLint.RuleListener = {
// ArrayExpression
ArrowFunctionExpression(node) {
if (node.body.type !== AST_NODE_TYPES.TSAsExpression) {
return rules.ArrowFunctionExpression(node);
}
},
// AssignmentExpression
// AwaitExpression
BinaryExpression: binaryExp,
CallExpression: callExp,
// ClassDeclaration
// ClassExpression
ConditionalExpression(node) {
// reduces the precedence of the node so the rule thinks it needs to be wrapped
if (node.test.type === AST_NODE_TYPES.TSAsExpression) {
return rules.ConditionalExpression({
...node,
test: {
...node.test,
type: AST_NODE_TYPES.SequenceExpression as any,
},
});
}
if (node.consequent.type === AST_NODE_TYPES.TSAsExpression) {
return rules.ConditionalExpression({
...node,
consequent: {
...node.consequent,
type: AST_NODE_TYPES.SequenceExpression as any,
},
});
}
if (node.alternate.type === AST_NODE_TYPES.TSAsExpression) {
// reduces the precedence of the node so the rule thinks it needs to be rapped
return rules.ConditionalExpression({
...node,
alternate: {
...node.alternate,
type: AST_NODE_TYPES.SequenceExpression as any,
},
});
}
return rules.ConditionalExpression(node);
},
// DoWhileStatement
'ForInStatement, ForOfStatement'(
node: TSESTree.ForInStatement | TSESTree.ForOfStatement,
) {
if (node.right.type === AST_NODE_TYPES.TSAsExpression) {
// makes the rule skip checking of the right
return rules['ForInStatement, ForOfStatement']({
...node,
type: AST_NODE_TYPES.ForOfStatement as any,
right: {
...node.right,
type: AST_NODE_TYPES.SequenceExpression as any,
},
});
}
return rules['ForInStatement, ForOfStatement'](node);
},
ForStatement(node) {
// make the rule skip the piece by removing it entirely
if (node.init && node.init.type === AST_NODE_TYPES.TSAsExpression) {
return rules.ForStatement({
...node,
init: null,
});
}
if (node.test && node.test.type === AST_NODE_TYPES.TSAsExpression) {
return rules.ForStatement({
...node,
test: null,
});
}
if (node.update && node.update.type === AST_NODE_TYPES.TSAsExpression) {
return rules.ForStatement({
...node,
update: null,
});
}
return rules.ForStatement(node);
},
// IfStatement
LogicalExpression: binaryExp,
MemberExpression(node) {
if (node.object.type === AST_NODE_TYPES.TSAsExpression) {
// reduces the precedence of the node so the rule thinks it needs to be wrapped
return rules.MemberExpression({
...node,
object: {
...node.object,
type: AST_NODE_TYPES.SequenceExpression as any,
},
});
}
return rules.MemberExpression(node);
},
NewExpression: callExp,
// ObjectExpression
// ReturnStatement
// SequenceExpression
SpreadElement(node) {
if (node.argument.type !== AST_NODE_TYPES.TSAsExpression) {
return rules.SpreadElement(node);
}
},
SwitchCase(node) {
if (node.test.type !== AST_NODE_TYPES.TSAsExpression) {
return rules.SwitchCase(node);
}
},
// SwitchStatement
ThrowStatement(node) {
if (
node.argument &&
node.argument.type !== AST_NODE_TYPES.TSAsExpression
) {
return rules.ThrowStatement(node);
}
},
UnaryExpression: unaryUpdateExpression,
UpdateExpression: unaryUpdateExpression,
// VariableDeclarator
// WhileStatement
// WithStatement - i'm not going to even bother implementing this terrible and never used feature
YieldExpression(node) {
if (
node.argument &&
node.argument.type !== AST_NODE_TYPES.TSAsExpression
) {
return rules.YieldExpression(node);
}
},
};
return Object.assign({}, rules, overrides);
},
});