fix(eslint-plugin): [no-var-requires] do not report require created f…

…rom createRequire (#4221)
typescript-eslint · Nov 28, 2021 · 0040186 · 0040186
1 parent 853d799
commit 0040186
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-var-requires.ts b/packages/eslint-plugin/src/rules/no-var-requires.ts
@@ -1,4 +1,5 @@
 import {
+  ASTUtils,
   AST_NODE_TYPES,
   TSESTree,
 } from '@typescript-eslint/experimental-utils';
@@ -43,10 +44,14 @@ export default util.createRule<Options, MessageIds>({
             AST_NODE_TYPES.VariableDeclarator,
           ].includes(parent.type)
         ) {
-          context.report({
-            node,
-            messageId: 'noVarReqs',
-          });
+          const variable = ASTUtils.findVariable(context.getScope(), 'require');
+
+          if (!variable?.identifiers.length) {
+            context.report({
+              node,
+              messageId: 'noVarReqs',
+            });
+          }
         }
       },
     };

diff --git a/packages/eslint-plugin/tests/rules/no-var-requires.test.ts b/packages/eslint-plugin/tests/rules/no-var-requires.test.ts
@@ -10,6 +10,11 @@ ruleTester.run('no-var-requires', rule, {
     "import foo = require('foo');",
     "require('foo');",
     "require?.('foo');",
+    `
+import { createRequire } from 'module';
+const require = createRequire('foo');
+const json = require('./some.json');
+    `,
   ],
   invalid: [
     {