feat(typescript-estree): support TSv4 labelled tuple members (#2378)

typescript-eslint · Aug 9, 2020 · 00d84ff · 00d84ff
1 parent 470174a
commit 00d84ff
Show file tree

Hide file tree

Showing 29 changed files with 3,004 additions and 109 deletions.
diff --git a/.prettierignore b/.prettierignore
@@ -15,3 +15,7 @@ CONTRIBUTORS.md
 
 # Ignore CHANGELOG.md files to avoid issues with automated release job
 CHANGELOG.md
+
+# TODO - remove this once prettier supports labelled tuples
+packages/scope-manager/tests/fixtures/type-declaration/tuple-labelled.ts
+packages/scope-manager/tests/fixtures/type-declaration/tuple-labelled-rest.ts
diff --git a/packages/eslint-plugin/src/rules/no-unused-vars-experimental.ts b/packages/eslint-plugin/src/rules/no-unused-vars-experimental.ts
@@ -140,7 +140,6 @@ export default util.createRule<Options, MessageIds>({
         case ts.SyntaxKind.ImportSpecifier:
         // a namespace import is NOT used, but the default import is used
         case ts.SyntaxKind.NamespaceImport:
-          // eslint-disable-next-line @typescript-eslint/internal/prefer-ast-types-enum
           report('Import');
           break;
 

diff --git a/packages/eslint-plugin/tests/rules/no-unused-vars-experimental.test.ts b/packages/eslint-plugin/tests/rules/no-unused-vars-experimental.test.ts
@@ -972,7 +972,6 @@ export function foo([[a]], used) {
           messageId: 'unusedWithIgnorePattern',
           data: {
             name: 'foo',
-            // eslint-disable-next-line @typescript-eslint/internal/prefer-ast-types-enum
             type: 'Import',
             pattern: DEFAULT_IGNORED_REGEX,
           },
@@ -1047,7 +1046,6 @@ console.log(named);
           messageId: 'unusedWithIgnorePattern',
           data: {
             name: 'defaultImp',
-            // eslint-disable-next-line @typescript-eslint/internal/prefer-ast-types-enum
             type: 'Import',
             pattern: DEFAULT_IGNORED_REGEX,
           },
@@ -1067,7 +1065,6 @@ console.log(named);
           messageId: 'unusedWithIgnorePattern',
           data: {
             name: 'defaultImp',
-            // eslint-disable-next-line @typescript-eslint/internal/prefer-ast-types-enum
             type: 'Import',
             pattern: DEFAULT_IGNORED_REGEX,
           },
@@ -1087,7 +1084,6 @@ console.log(defaultImp);
           messageId: 'unusedWithIgnorePattern',
           data: {
             name: 'named',
-            // eslint-disable-next-line @typescript-eslint/internal/prefer-ast-types-enum
             type: 'Import',
             pattern: DEFAULT_IGNORED_REGEX,
           },
@@ -1107,7 +1103,6 @@ console.log(defaultImp);
           messageId: 'unusedWithIgnorePattern',
           data: {
             name: 'named',
-            // eslint-disable-next-line @typescript-eslint/internal/prefer-ast-types-enum
             type: 'Import',
             pattern: DEFAULT_IGNORED_REGEX,
           },
@@ -1127,7 +1122,6 @@ console.log(named1);
           messageId: 'unusedWithIgnorePattern',
           data: {
             name: 'named2',
-            // eslint-disable-next-line @typescript-eslint/internal/prefer-ast-types-enum
             type: 'Import',
             pattern: DEFAULT_IGNORED_REGEX,
           },