From 04288f780f36846bbdd5ce6511b836fcd50b36ba Mon Sep 17 00:00:00 2001 From: Pete Gonzalez <4673363+octogonz@users.noreply.github.com> Date: Wed, 31 Jul 2019 16:09:22 -0700 Subject: [PATCH] chore: add some more tests --- .../eslint-plugin/tests/rules/typedef.test.ts | 34 +++++++++++++++++-- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/packages/eslint-plugin/tests/rules/typedef.test.ts b/packages/eslint-plugin/tests/rules/typedef.test.ts index c886fbcb12f..7a8270ed83c 100644 --- a/packages/eslint-plugin/tests/rules/typedef.test.ts +++ b/packages/eslint-plugin/tests/rules/typedef.test.ts @@ -101,7 +101,7 @@ ruleTester.run('typedef', rule, { }, ], }, - // Parameters + // Function parameters `function receivesNumber(a: number): void { }`, `function receivesStrings(a: string, b: string): void { }`, `function receivesNumber([a]: [number]): void { }`, @@ -109,6 +109,13 @@ ruleTester.run('typedef', rule, { `function receivesString({ a }: { a: string }): void { }`, `function receivesStrings({ a, b }: { [i: string ]: string }): void { }`, `function receivesNumber(a: number = 123): void { }`, + // Method parameters + `class Test { + public method(x: number): number { return x; } + }`, + `class Test { + public method(x: number = 123): number { return x; } + }`, // Property declarations `type Test = { member: number; @@ -292,7 +299,7 @@ ruleTester.run('typedef', rule, { }, ], }, - // Parameters + // Function parameters { code: `function receivesNumber(a): void { }`, errors: [ @@ -351,6 +358,29 @@ ruleTester.run('typedef', rule, { }, ], }, + // Method parameters + { + code: `class Test { + public method(x): number { return x; } + }`, + errors: [ + { + column: 23, + messageId: 'expectedTypedefNamed', + }, + ], + }, + { + code: `class Test { + public method(x = 123): number { return x; } + }`, + errors: [ + { + column: 23, + messageId: 'expectedTypedef', + }, + ], + }, // Property declarations { code: `type Test = {